Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582864 Kalev Lember <kalev@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalev@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kalev@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-04-16 10:06:09 EDT --- Fedora review qtlockedfile-2.4-1.fc12.src.rpm 2010-04-16 + OK ! needs attention rpmlint output: qtlockedfile.i686: W: spelling-error Summary(en_US) QFile -> Q File, File, Filled qtlockedfile.i686: W: unused-direct-shlib-dependency /usr/lib/libQtSolutions_LockedFile-2.4.so.1.0.0 /usr/lib/libQtGui.so.4 qtlockedfile.i686: W: unused-direct-shlib-dependency /usr/lib/libQtSolutions_LockedFile-2.4.so.1.0.0 /lib/libm.so.6 qtlockedfile.src: W: spelling-error Summary(en_US) QFile -> Q File, File, Filled qtlockedfile.src:39: W: configure-without-libdir-spec 4 packages and 0 specfiles checked; 0 errors, 5 warnings. ! Most of the rpmlint warnings above are harmless and can be ignored, but the unused-direct-shlib-dependency libQtGui.so.4 is something that drags in unneeded qt-x11 package. If it's easy to fix it might be worth looking into. + The package is named according to the Package Naming Guidelines. + Spec file name matches the base package name + The package follows the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The package contains license files (LGPL_EXCEPTION.txt, LICENSE.GPL3, and LICENSE.LGPL) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: ac8f848f59038a414f3ab4f4cc08e99c qtlockedfile-2.4_1-opensource.tar.gz ac8f848f59038a414f3ab4f4cc08e99c Download/qtlockedfile-2.4_1-opensource.tar.gz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a The spec file MUST handle locales properly + ldconfig is properly called in %post and %postun + Package does not bundle copies of system libraries n/a Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set and %files has %defattr + Consistent use of macros + Package contains code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package + Header files are in -devel n/a Static libraries should be in -static + Library files that end in .so must go in a -devel package + -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + Filenames must be valid UTF-8 I'll wait with approving this package until you've replied about the unused-direct-shlib-dependency libQtGui.so.4, but besides that everything looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review