Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580873 --- Comment #2 from Jindrich Novy <jnovy@xxxxxxxxxx> 2010-04-15 10:03:16 EDT --- Thanks, new scratch build (including SRPM) is located here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2117077 > libdb-cxx.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_cxx-5.0.so > 0775 > > 0755? I saw no 0775 permissions in the output rpms but added fix to enforce 0755 permissions for every library. > libdb-devel-static.x86_64: W: spelling-error %description -l en_US statical -> > statically, statistical, static > > First and third variants sounds better. Fixed. > libdb-devel.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/libdb-devel-5.0.21/csharp/LoadIndexKeywords.aspx > > Mostly cosmetic, worth to fix? The C# documentation should go away and it is gone now :) > libdb-sql.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dbsql > ['/usr/lib64'] > > rpath should be killed. Added --disable-rpath to configure and using chrpath -d to be sure. > libdb-sql.x86_64: W: devel-file-in-non-devel-package /usr/include/libdb/dbsql.h > > libdb-sql-devel for one file or OK as is? Yep, I would leave it as is. The tiny header file is not worth a separate subpackage. > libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_printlog > ['/usr/lib64'] > > rpath should be killed. It is now killed. > [YES] Package meets naming guidelines. > > Please use integer release if pushed to CVS. the 0.x release is used for review only. The first version will be 1 and on. > [YES] BuildRequires is correct. > > There is no need to list util-linux-ng, see exception. Removed. > [?] ldconfig is called in %post/%postun for every package with DSO > > It seems the ldconfig is not called for cxx subpackage. Added. > [NO] Permission on files are set properly. > > deffatr should be (-,root,root,-). > > Some libraries are installed with mode 0775, see rpmlint output above. Fixed. > [NO] Devel packages must require the base package using a fully versioned > dependency. > > There is no dependency in devel-static subpackage. > > Missing dependency for cxx subpackage, is that OK? Added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review