Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581723 --- Comment #1 from ELMORABITY Mohamed <pikachu.2014@xxxxxxxxx> 2010-04-13 01:47:44 EDT --- Hi, just a few comments before a potential review. 1) You don't need to add kernel-headers as a BuildRequires, since it is a dependancy of gcc, and gcc an implicit BuildRequires. So remove kernel-headers in your BR. 2) You don't need also to set e2fsprogs as a Requires. Your binary is dynamically linked to libext2fs.so, and this library is set automatically as a Requires when your RPM is built. Moreover your binary doesn't call any executable from the e2fsprogs package. So remove e2fsprogs in your Requires. 3) The binary is not compiled with the Fedora flags (see https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags). You should patch the Makefile to make it use CXXFLAGS and then set the value of CXXFLAGS to $RPM_OPT_FLAGS in your .spec file... Or even ask upstream to write better Makefiles :-P 4) Not very important, but your description and your summary are the same. Maybe you can develop your Description like this: "extundelete is a utility that can recover deleted files from an ext3 or ext4 partition. extundelete uses the information stored in the partition's journal to attempt to recover a file that has been deleted from the partition. There is no guarantee that any particular file will be able to be undeleted, so always try to have a good backup system in place, or at least put one in place after recovering your files! " (taken from the project website; I think it is better since we have a warning about the fact that extundelete is not infallible). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review