Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 ------- Additional Comments From pertusus@xxxxxxx 2006-10-21 21:18 EST ------- This is in much better shape! The Editor wrapper seems to be almost what is needed. I have a small patch for it, to check for config file only if there is no argument. * I also propose to standardize the libtcd building such that it can be done with export CFLAGS="$RPM_OPT_FLAGS -DCOMPAT114" %configure %{__make} %{?_smp_mflags} \ %if %{build_libtcd} libtcd.so \ SOMAJOR=`echo %{libtcd_soname} | sed -e 's|^\(.*\)\.\(.*\)\.\(.*\)$|\1|'` \ SOMINOR=`echo %{libtcd_soname} | sed -e 's|^\(.*\)\.\(.*\)\.\(.*\)$|\2|'` \ SOVER=` echo %{libtcd_soname} | sed -e 's|^\(.*\)\.\(.*\)\.\(.*\)$|\3|'` %endif I attach the updated libtcd-2.3.1-shared.patch. * Now there is the issue of missing dependency of tideEditor and xttpd which requires /etc/xtide.conf and /usr/share/xtide/harmonics-2004-06-14.tcd. To workaround this issue I propose to add a package which will contain those common datas, called, for example tcd-utils-data and which will contain %dir %{_datadir}/%{name} %{_datadir}/%{name}/harmonics-*.tcd %config(noreplace) %{_sysconfdir}/%{name}.conf And then xtide, tcd-utils and xttpd would have a Requires: tcd-utils-data = %{tcdutils_ver}-%{tcdutils_rel}%{?dist} * There is a strange $f on the following line %{__install} -c -p -m755 libtcd.so.*.*.* $f $RPM_BUILD_ROOT%{_libdir} * In my opinion /etc/xttpd.conf should be instead /etc/sysconfig/xttpd, with the corresponding adjustment of xttpd.init -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review