Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573932 --- Comment #14 from Marcela Mašláňová <mmaslano@xxxxxxxxxx> 2010-04-12 08:07:02 EDT --- (In reply to comment #13) > Alright! So. :) > > The invocation of %{?perl_default_filter} needs to be done before the first > %description stanza in the spec file. If you're not invoking any other > filtering macros, the %{?perl_default_filter} incantation is sufficiently > conditionalized without wrapping it in %{?filter_setup: ... }. DONE > > Looks like we need Test::Pod; and t/020isize.t needs COMPRESS_ZLIB_RUN_ALL=1 > set and Test::NoWarnings BR'ed to run all its tests. t/020isize.t takes forever so I didn't add this variable into 'make test' > > %files needs a '%exclude %dir %{perl_archlib}/auto'. There's an examples/ > directory in the tarball; why not include it under %doc? Similarly, theres a > pod/FAQ.pod. I've excluded %{perl_privlib}/auto because this should be noarch package. > > The %description is a touch misleading, as modules like IO::Compress::Gzip are > most certainly intended to be used by application code. Perhaps the part > under "DESCRIPTION" in the README would work better? DONE > > And, it looks like this is being built as "noarch" but is still installing > (and packaging) files under the arch-specific %perl_archlib... which is not > entirely optimal :) The files should either be under %perl_privlib or the > package should be built for each supported architecture. Tests in Makefile probably didn't work well in our case. I wrote a Fedora patch which set perl_privlib as installation path. > > Update as described above, and I'll approve :) Not sure if you are content now ;-) http://mmaslano.fedorapeople.org/review/perl-IO-Compress-2.024-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review