Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580830 --- Comment #2 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-04-11 11:03:02 EDT --- Some comments: # Summary: Command Line Interface That's seems a bit short. # Group: Applications Wrong, might be System Environment/Shells # License: GPL Wrong, must specify version GPL v1, v2 or v3? # URL: Please fill in. # Source0: http://sourceforge.net/projects/clish/files/clish/0.7.3/%{name}-%{version}.tar.gz Wrong, ref: https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net # BuildRequires: autoconf # BuildRequires: automake # BuildRequires: libtool Is those needed? # %description # Command Line Interface # A modular framework for implementing a CISCO-like CLI on a *NIX system. # Arbitary command menus and actions can be defined using XML files. This # software handles the user interaction, and forks the appropriate system # commands to perform any actions. # Too long line, keep < 80 chars. # %install # rm -rf $RPM_BUILD_ROOT # make install DESTDIR=$RPM_BUILD_ROOT Add INSTALL="install -p" to preserve timestamps # install -d ${RPM_BUILD_ROOT}%{_sysconfdir}/clish # install -m 775 xml-examples/* ${RPM_BUILD_ROOT}%{_sysconfdir}/clish/ ditto. # %files # %defattr(644,root,root,755) use %defattr(-,root,root,-) # %doc Empty? # %attr(755,root,root) %{_libdir}/lib*.so.*.* # %attr(755,root,root) %{_bindir}/* # %attr(755,root,root) %{_libdir}/lib*.so # %attr(755,root,root) %{_libdir}/lib*.so.* Remove %attr and list files a bit more explicit. # %{_libdir}/lib*.la Don't include la files, remove in install # %{_includedir}/clish/*.h # %{_includedir}/lub/*.h # %{_includedir}/tinyrl/*.h # %{_includedir}/tinyxml/*.h Move to devel subpackage # %{_libdir}/lib*.a Don't include a files, remove in install %{_sysconfdir}/clish/*.xml %{_sysconfdir}/clish/*.txt %{_sysconfdir}/clish/README %{_sysconfdir}/clish/*.am I would prefer only *.xml here (real config files in /etc, for documentation use %doc) # %define date %(echo `LC_ALL="C" date +"%a %b %d %Y"`) A new one, please remove and use the common pattern. # %changelog # * %{date} Devil Wang <wxjeacen at fedoraproject.org> # - Initial Introduction <wxjeacen AT,gmail.com> Not according to guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review