Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581161 --- Comment #2 from Arun SAG <sagarun@xxxxxxxxx> 2010-04-10 14:21:00 EDT --- (In reply to comment #1) > A few quick notes on your specfile: > * You should use macros in the Source URL in line 9: > http://wirelessdefence.org/Contents/Files/%{name}-%{version}.tgz Agreed :-) . I don't know how i missed it. > * I think using the macro in the description (line 14) is not an appropriate > elegant solution Agreed. > * You should use make, rm and install directly instead of the macros (lines 25, > 28, 29, 30 and 34) Before people have recommended using macros instead of direct commands. May i know the reason for your suggestion? > * The BuildRoot-tag in line 10 is not necessary anymore as per guideline [1], > you can remove it at your > option unless you like to push your package also in EPEL Agreed. Will remove that line. > * You can use the name macro in the target paths in lines 29 and 40 instead of > writing "cowpatty" Agreed . Will use macros. > * You have 79 chars per line for your description, but you're actually using > just 53 per line. Maybe you like > to improve that :) > Will make use of 79 chars per line :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review