Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579514 --- Comment #2 from Christian Krause <chkr@xxxxxxxxxxx> 2010-04-10 13:01:09 EDT --- Orcan, thanks for the review! (In reply to comment #1) > ! Group tag should probably be "System Environment/Libraries" Done. > * DS_Store files need to be removed in %prep as per the guidelines. Maybe the > whole packaging/ directory should be removed? Done, removed the complete packaging/ directory. > ! CHANGELOG file, and tests/ directorf might be packaged as %doc. Done. > ! We prefer %defattr(-,root,root, -) most of the time Done. > ! Simply "python" can be used instead of %{__python} for macro consistency. Or > "%{__rm}" can be used instead of "rm". Done, I have chosen the variant without macros. > ! The package provides _portaudio.so(). I hope this doesn't result in a > conflict. It looks like that this is some kind of standard to package the glue-libraries as _name.so: ls /usr/lib/python2.6/site-packages/*.so Since normal libraries usually provide something like: rpm -q --provides portaudio libportaudio.so.2 libportaudiocpp.so.0 and the python glue libs provide rpm -q --provides pyaudio _portaudio.so any conflicts are prevented (no "lib" prefix but "_" as an additional prefix). > * Python guidelines changed a bit recently. Accordingly, > * We need to use BuildRequires: python2-devel Done. > ! Also please check the macros section in the new guidelines. > - I think the rest is fine. But as I am not that familiar with the new > python packaging guidelines, I advise you to go through the page once. > We might have missed something. > See: > http://fedoraproject.org/wiki/Packaging/Python I have made the definition of the %python_sitearch optional (only for F-12 and earlier) as it was suggested. The other changes and/or macros are only useful for python3 packages. Spec URL: http://chkr.fedorapeople.org/review/pyaudio.spec SRPM URL: http://chkr.fedorapeople.org/review/pyaudio-0.2.3-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review