Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542458 --- Comment #10 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-04-09 10:53:12 EDT --- 1 MUST: missing upstream project URL: tag 2 MUST: Source: tags should contain full URLs (to at least be able to verify validity of upstream sources) If a full URL cannot be provided, please include a comment in the .spec explaining why. See https://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source 3 MUST: Version tag is strange, 2.1Qt4.5.3 , I'd suggest using simply Version: 2.1 I don't see much purpose encoding Qt or qt version here. See https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Version 4 MUST: many of the BuildRequires: are superfluous or not needed, I'd suggest trimming them down to simply: BuildRequires: libxml2-devl BuildRequires: qt4-devel See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires 5 MUST: Requires can be reduced to just: Requires: qt4%{?_isa} >= %{_qt4_version} See https://fedoraproject.org/wiki/Packaging/Guidelines#Requires 6 MUST: scripts can be adjusted to: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig See https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries 7 SHOULD: can use %{qt4_qmake} macro instead of qmake-qt4 (but that's up to you). 8 SHOULD: in %build, use make %{?_smp_mflags} if parallel make isn't supported, please add comment in .spec saying why 9 MUST: Summary: Qt4 interface bindings is vague, please adjust to mention Pascal, maybe something like Summary: Qt4 interface bindings for Pascal 10 MUST: -devel subpkg requires should be tightened to: Requires: %{name} = %{version}-%{release} See https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package 11 MUST: Group: tags invalid (or missing), I suggest Group: System Environment/Libraries and for -devel subpkg Group: Development/Libraries 12 MUST: License tag invalid, use License: LGPLv2+ instead. See https://fedoraproject.org/wiki/Licensing#Good_Licenses 13 SHOULD: use of %{?dist} is highly recommended, I'd suggest using Release: 1%{?dist} Seehttps://fedoraproject.org/wiki/Packaging/NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review