Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566408 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-08 14:47:53 EDT --- Hi Nikolay, here is the formal review of proxytunnel. The package is pretty clean, I just suggest the following minor cosmetic improvements: - in Source0, use macro %{name} instead of "proxytunnel": http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tgz - to ensure that only section 1 man pages are added to man1, replace %{_mandir}/man1/proxytunnel* with %{_mandir}/man1/proxytunnel.1* $ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm proxytunnel.src: W: spelling-error %description -l en_US stdin -> stein, stain, stdio proxytunnel.src: W: spelling-error %description -l en_US stdout -> stout, std out, std-out proxytunnel.x86_64: W: spelling-error %description -l en_US stdin -> stein, stain, stdio proxytunnel.x86_64: W: spelling-error %description -l en_US stdout -> stout, std out, std-out 3 packages and 0 specfiles checked; 0 errors, 4 warnings. These spelling warnings can be ignored. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum proxytunnel-1.9.0.tgz* d74472b89c3f3b3b0abf6bd809ae34c2 proxytunnel-1.9.0.tgz d74472b89c3f3b3b0abf6bd809ae34c2 proxytunnel-1.9.0.tgz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. koji scratch builds: F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2103282 F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2103246 [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: .so (without suffix) must go in a -devel package. [.] MUST: devel packages must require the base package using a fully versioned dependency [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [+] SHOULD: your package should contain man pages for binaries/scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review