Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580317 Sebastian Dziallas <sebastian@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Sebastian Dziallas <sebastian@xxxxxxxx> 2010-04-08 13:22:38 EDT --- Here we go. You might want to look into the licensing thing - besides that, there only minor things, so after that it should be good to go. [ OK ] specfiles match: f17ae94c32cca78259ad8310cf048f8b [ OK ] source files match upstream: fc8c42d8c20a7f99ee7f02a2df31106d [ OK ] package meets naming and versioning guidelines. [ -- ] spec is properly named, cleanly written, and uses macros consistently. Do you need %{?extra_release} or can you drop that? [ OK ] dist tag is present. [ OK ] build root is correct. [ -- ] license field matches the actual license. I'm not entirely sure on this one, but the licensing guidelines say: "The License: field refers to the licenses of the contents of the binary rpm." However, there seems to be a jquery copy in the final RPM which is apparently "Dual licensed under the MIT and GPL licenses." -- I suppose you might need to add these there. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=2102768 [ -- ] package installs properly. Warning in file "/usr/share/applications/gnome-nautilus-folder-handler.desktop": usage of MIME type "x-directory/gnome-default-handler" is discouraged ("x-directory" is an old media type that should be replaced with a modern equivalent) Warning in file "/usr/share/applications/gnome-nautilus-folder-handler.desktop": usage of MIME type "x-directory/normal" is discouraged ("x-directory" is an old media type that should be replaced with a modern equivalent) [ OK ] debuginfo package looks complete. [ -- ] rpmlint is silent: [sebastian@localhost ~]$ rpmlint entangle-* entangle.src: W: spelling-error %description -l en_US libgphoto -> telephoto, photogenic, photocell entangle.i686: W: spelling-error %description -l en_US libgphoto -> telephoto, photogenic, photocell entangle.i686: W: wrong-file-end-of-line-encoding /usr/share/entangle/website/jquery.fancybox/jquery.fancybox.css 3 packages and 0 specfiles checked; 0 errors, 3 warnings. [ OK ] final provides and requires are sane [ NA ] %check is present and all tests pass [ OK ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ NA ] docs subpackage is appropriately created [ OK ] %docs are not necessary for the proper functioning of the package. [ NA ] headers go into devel package. [ NA ] pkgconfig files are in devel package. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review