Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570457 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-04-06 04:40:10 EDT --- Some notes: * (Build)Requires - The following Requires are all not needed. These are for development dependencies, not for runtime: ------------------------------------------------------------ Requires: rubygem(rubyforge) >= 2.0.3 Requires: rubygem(gemcutter) >= 0.3.0 Requires: rubygem(hoe) >= 2.5.0 ------------------------------------------------------------ - The correct dependency should be "rubygem(right_http_connection)" - As lib/right_rackspace.rb contains: ------------------------------------------------------------ 29 require 'json' ------------------------------------------------------------ This package should have "Requires: rubygem(json)" * %check - As this package contains test/ directory, please add %check section and execute some test program there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review