Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542765 --- Comment #8 from Carl Byington <carl@xxxxxxxxxxxxxxx> 2010-04-05 16:58:51 EDT --- exit in library - yes, that seems to be the way they wrote the code, and I don't see that changing since there are a LOT of such calls. data files license - the amber and tripos data files are public domain, and used in a many other chemistry packages. I will check with upstream, but I doubt there is a more explicit license. I added a bit of description for the libghemical package. Removed unnecessary build-requires. rpmlint undefined-non-weak-symbol vs. unused-direct-shlib-dependency : for an example, if we don't add -ldl, then we get dlopen as an undefined-non-weak-symbol. If we do add -ldl, we get unused-direct-shlib-dependency for dlopen.so. I have opted to prevent the undefined-non-weak-symbol errors. The upstream autoconf packaging does not seem to pickup the proper mpqc libraries, unless we override 'make LIBS=', which overrides everything. Unless we want to redo the whole autoconf package, overriding LIBS= seems to work. http://www.five-ten-sg.com/libghemical.spec http://www.five-ten-sg.com/libghemical-2.99.1-13.fc12.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=2096296 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review