Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570424 Dominic Hopf <dmaphy@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review?, |fedora-review+ |needinfo?(dmaphy@fedoraproj | |ect.org) | --- Comment #6 from Dominic Hopf <dmaphy@xxxxxxxxxxxxxxxxx> 2010-04-05 16:43:17 EDT --- (In reply to comment #4) > > [!] %{buildroot} is removed at beginning of %install > According to http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag, > cleaning up of buildroot isn't required from Fedora 10 onwards. Satya, the mentioned guideline just allows you to omit the BuildRoot-tag at the beginning of the file. This is not the same as the %{buildroot} macro or the $RPM_BUILD_ROOT variable. rpmlint still claims, that the 'rm -rf %{buildroot}' command at the beginning of the %install section is missing. It wouldn't if it really was obsolete. Please add it before requesting CVS access. :) > > [!] Package contains latest upstream version > > * While checking the sha1sum I noted there were some changes on the code just > > today, maybe you want to update the file and the release tag accordingly > > then? > Corrected. > > > [!] Package builds in mock > > Tested on: F12/x86_64; see my note concerning README.md below > > * The installation of the README.md is not okay yet. The file actually would > > get installed in /, which obviuously is not the right place for documentation > > files. > --snip-- > Corrected > > > * You should write down in your ChangeLog what you actually changed in the > > package or rather in the specfile > Corrected > > > * The release number should always begin with 0. > --snip-- > Corrected. > > > The updated spec file may be found at: > http://sundaram.fedorapeople.org/packages/transmission-remote-cli.spec > > And the updated SRPM is at: > http://sundaram.fedorapeople.org/packages/transmission-remote-cli-0.5.5-0.3.20100310git.fc12.src.rpm Thanks very much for correcting the mentioned isssues and for your patience. I'm sorry I was a bit stressed the last weeks and had lot of things to do at work, which caused my delayed answer to this issue. Except the mentioned issue with the %install section, your package looks good now and is APPROVED. Remember to add the 'rm -rf %{buildroot}' to the %install section before requesting the CVS access. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review