Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570810 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-04-05 14:32:00 EDT --- Some notes: * Unused / defined macros - %ruby_sitelib seems to be used nowhere - As %geminstdir is defined, please use this macro in %files when applicable. * %define -> %global - We now prefer to use %global instead of %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * License - When the software says "This is distributed under the same license Ruby is", the license tag on Fedora should be "GPLv2 or Ruby" * (Build)Requires - "Requires: rubygem(rcov)" is not needed. --------------------------------------------------- BuildRequires: rubygems Requires: rubygems Requires: ruby(rubygems) --------------------------------------------------- - Please use one style for (Build)Requires: rubygems * Duplicate %files entry --------------------------------------------------- 57 Processing files: rubygem-net-dns-0.6.1-1.fc13.noarch 58 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/AUTHORS.rdoc 59 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/CHANGELOG.rdoc 60 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/README.rdoc 61 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/net-dns-0.6.1/THANKS.rdoc --------------------------------------------------- - Please make it sure that every directory / file is listed only once. * %check - As this gem contains test/ directory, please add %check section and execute some test programs there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review