Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579299 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2010-04-05 02:23:06 EDT --- + source files match upstream. fc732ff0509fb5475f0ccb0710e62878 Test-LeakTrace-0.10.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2093808 + package installs properly. + rpmlint has no serious complaints: perl-Test-LeakTrace.src: I: checking perl-Test-LeakTrace.src: W: spelling-error %description -l en_US ok -> OK, och, pk perl-Test-LeakTrace.src: W: spelling-error %description -l en_US cmp -> cm, mp, camp perl-Test-LeakTrace.src: I: checking-url http://search.cpan.org/dist/Test-LeakTrace (timeout 10 seconds) perl-Test-LeakTrace.src: I: checking-url http://search.cpan.org/CPAN/authors/id/G/GF/GFUJI/Test-LeakTrace-0.10.tar.gz (timeout 10 seconds) perl-Test-LeakTrace.x86_64: I: checking perl-Test-LeakTrace.x86_64: W: spelling-error %description -l en_US ok -> OK, och, pk perl-Test-LeakTrace.x86_64: W: spelling-error %description -l en_US cmp -> cm, mp, camp perl-Test-LeakTrace.x86_64: I: checking-url http://search.cpan.org/dist/Test-LeakTrace (timeout 10 seconds) perl-Test-LeakTrace-debuginfo.x86_64: I: checking perl-Test-LeakTrace-debuginfo.x86_64: I: checking-url http://search.cpan.org/dist/Test-LeakTrace (timeout 10 seconds) perl-Test-LeakTrace-tests.x86_64: I: checking perl-Test-LeakTrace-tests.x86_64: I: checking-url http://search.cpan.org/dist/Test-LeakTrace (timeout 10 seconds) perl-Test-LeakTrace-tests.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. + final provides and requires are sane: perl(Test::LeakTrace) = 0.10 perl-Test-LeakTrace = 0.10-1.fc13 perl(Test::LeakTrace::Script) perl-Test-LeakTrace(x86-64) = 0.10-1.fc13 = libc.so.6()(64bit) libc.so.6(GLIBC_2.11)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) perl >= 0:5.008_001 perl(Exporter) perl(Exporter) >= 5.57 perl(:MODULE_COMPAT_5.10.1) perl(strict) perl(Test::Builder::Module) perl(Test::LeakTrace) perl(warnings) perl(XSLoader) + %check is present and all tests pass. # Testing Test::LeakTrace/0.10 t/00_compile.t ..... ok t/01_info.t ........ ok t/02_refs.t ........ ok t/03_count.t ....... ok t/04_test_funcs.t .. ok t/05_script.t ...... ok t/06_threads.t ..... ok t/07_eval.t ........ ok t/08_leaktrace.t ... ok t/09_info_more.t ... ok t/10_bad_use.t ..... ok t/11_logfp.t ....... ok t/12_padstale.t .... ok All tests successful. Files=13, Tests=121, 0 wallclock secs ( 0.02 usr 0.03 sys + 0.52 cusr 0.13 csys = 0.70 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review