Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=574342 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-04-04 14:25:47 EDT --- Initial comments: * Requires/BuildRequires - ">= 0.3.2" for (Build)Requires: rubygem(xmpp4r) is redundant because the least version of rubygem-xmpp4r on Fedora is 0.5. - ">= 0" for (Build)Requires is redundant. * Macros - As %geminstdir is defined, please use this defined even in %files * Duplicate %files entry - From build.log: ------------------------------------------------------------- 56 Processing files: rubygem-xmpp4r-simple-0.8.8-1.fc13.noarch 57 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/COPYING 58 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/README ------------------------------------------------------------- And from $ rpm -qlp: ------------------------------------------------------------- $ rpm -qlp *rpm | sort | uniq -d /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/test /usr/lib/ruby/gems/1.8/gems/xmpp4r-simple-0.8.8/test/test_xmpp4r_simple.rb ------------------------------------------------------------- These files or directories are listed more than once. Please fix %files list so that all files/directories appear only once. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review