Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718 peter@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |peter@xxxxxxxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2006-10-21 03:14 EST ------- A brief comment before I start a formal review of this: Your %files section contains %{_bindir}, which means that the package will own /usr/bin (or whatever directory it expands to for the user's RPM macros). It should only own the specific binaries it provides. %{_bindir} and other system directories are owned by the fileystem package, and this is a Very Bad Thing(TM). (See http://fedoraproject.org/wiki/Packaging/Guidelines#head-a5931a7372c4a00065713430984fa5875513e6d4 for more information.) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review