Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575492 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flag| |fedora-review+ Bug 575492 depends on bug 575491, which changed state. Bug 575491 Summary: Review Request: perl-Test-SharedFork - Fork test https://bugzilla.redhat.com/show_bug.cgi?id=575491 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2010-04-03 00:31:07 EDT --- + source files match upstream. 16e0a9f1705437b0233b4b1d95e3dc04 Filesys-Notify-Simple-0.05.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2092343 + package installs properly. + rpmlint has acceptable complaints: perl-Filesys-Notify-Simple.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic perl-Filesys-Notify-Simple.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic perl-Filesys-Notify-Simple-tests.noarch: W: no-documentation perl-Filesys-Notify-Simple-tests.noarch: W: hidden-file-or-dir /usr/libexec/perl5-tests/Filesys-Notify-Simple/t/x/.placeholder perl-Filesys-Notify-Simple-tests.noarch: E: zero-length /usr/libexec/perl5-tests/Filesys-Notify-Simple/t/x/.placeholder 3 packages and 0 specfiles checked; 1 errors, 4 warnings. + final provides and requires are sane: perl(Filesys::Notify::Simple) = 0.05 perl-Filesys-Notify-Simple = 0.05-1.fc14 = perl >= 0:5.008_001 perl(Carp) perl(constant) perl(Cwd) perl(Linux::Inotify2) perl(:MODULE_COMPAT_5.10.1) perl(strict) + %check is present and all tests pass. t/00_compile.t .. ok t/rm_create.t ... ok All tests successful. Files=2, Tests=3, 6 wallclock secs ( 0.02 usr 0.01 sys + 0.09 cusr 0.02 csys = 0.14 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review