Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575170 --- Comment #8 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-04-02 20:44:32 EDT --- kdchart bundling taken care of. The other items from comment #4 are still outstanding: NEEDSWORK: * License field says GPLv2+ but it's really GPLv2 or GPLv3 due to the license of libkdchart. - I took a brief look at the source in koffice -- looks like anything that links to libkdgantt or libkdchart (both kdab products?) need to be GPLv2 OR GPLv3 instead of GPLv2+. * The question of online docs that are marked %doc * Whether to propose the desktop-file-validate and ScriptletSnippets changes to the packaging committee (nonblocker but we should figure out if this is something that we should update the best practices for). * The .directory files * /usr/share/kde4/apps/kmymoney/misc/financequote.pl => script without shebang * The world writable source files ending up in debug packages (I think the files might be generated during build so - do this during %install:: find . -type f -name '*.h' -exec chmod 0644 kmymoney) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review