Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573151 --- Comment #23 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2010-04-02 16:54:30 EDT --- (In reply to comment #21) > 1. It there any value in running some of the tests shipped in python26-test at > build time in %test? Or are those more standalone testing framework files? > (They look like they might be unit tests, but not sure how easily they would > be run) I've added a %check section which runs the tests (though I run them from the build directory, rather than the buildroot). I've listed the tests that are known to fail, and the %check ought to fail and halt the build if a test fails in one of the other suites (this is done on a per-file basis rather than a per-case basis, but it seems good for now). > 2. Looks like there are some files listed twice? Fixed > 3. Does the %{?_isa} dep with the devel package work in el5? > I think RHEL5 rpm is basically just ignoring this: Good catch. According to http://www.rpm.org/wiki/PackagerDocs/ArchDependencies , _isa was added in rpm 4.6.0, so, yes, this does nothing on a build with RHEL 5's rpm 4.4.2.3 It doesn't hurt though. Is it OK to keep, for consistency with Fedora, or should I drop it? > 4. rpmlint says a lot of things. Most of which can be ignored. (To be addressed; I wanted to give you an update on progress so far) New specfile: http://dmalcolm.fedorapeople.org/epel-packaging/python26.spec Diff from last SRPM: http://dmalcolm.fedorapeople.org/epel-packaging/from-python26-2.6.5-1-to-2.6.5-2.diff New SRPM: http://dmalcolm.fedorapeople.org/epel-packaging/python26-2.6.5-2.el5.src.rpm Successful scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2092150 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review