Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579072 --- Comment #1 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-04-02 11:33:47 EDT --- Looks good! The usual comments w.r.t. PERL_INSTALL_ROOT/DESTDIR and perl_default_filter apply. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2091206 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): a79b2086a874082a0b6908b444d39efdf16fb92f File-ShareDir-Install-0.03.tar.gz a79b2086a874082a0b6908b444d39efdf16fb92f File-ShareDir-Install-0.03.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-File-ShareDir-Install-0.03-1.fc14.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-File-ShareDir-Install-0.03-1.fc14.noarch.rpm perl(File::ShareDir::Install) = 0.03 perl-File-ShareDir-Install = 0.03-1.fc14 ====> requires for perl-File-ShareDir-Install-0.03-1.fc14.noarch.rpm perl >= 0:5.008 perl(Carp) perl(Exporter) perl(File::Spec) perl(IO::Dir) perl(:MODULE_COMPAT_5.10.1) perl(strict) perl(warnings) =====> perl-File-ShareDir-Install-0.03-1.fc14.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-File-ShareDir-Install-0.03-1.fc14.src.rpm ====> requires for perl-File-ShareDir-Install-0.03-1.fc14.src.rpm perl(ExtUtils::MakeMaker) >= 6.11 perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review