Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578981 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-02 09:31:43 EDT --- A couple of initial comments: - drop BR: gcc gcc-c++ (they are picked up automatically) - drop INSTALL from %doc - change the defattrs to %defattr(-,root,root,-) - remove %attr(0755,root,root) as the permissions are set automatically - .la files must not be packaged. Remove them in the %build section (see https://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries) - I suggest to use the %{name} macro instead of explicitly stating libdrizzle (in Source0, %files) - append a slash to directories, e.g. %{_includedir}/%{name}/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review