Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578620 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-02 04:25:10 EDT --- Hi Fabien, here's the formal review of quvi. The package is in pretty good shape. I just suggest to address the following minor cosmetic issues: - You can remove the redundant option "-n %{name}" from %post and %postun - append a slash to directories added in %files: %{_includedir}/%{name}/ This way it's easier to recognize that a folder is added - add a blank line between the changelog revisions The rpmlint warnings can be ignored, as the spelling is correct and Source0 URL is valid. $ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm quvi.src: W: invalid-url Source0: http://quvi.googlecode.com/files/quvi-0.1.3.tar.bz2 HTTP Error 404: Not Found quvi-devel.x86_64: W: spelling-error Summary(en_US) libquvi -> Libreville, Librium, libelous quvi-devel.x86_64: W: spelling-error %description -l en_US libquvi -> Libreville, Librium, libelous 4 packages and 0 specfiles checked; 0 errors, 3 warnings. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum quvi-0.1.3.tar.bz2* 12ac6a254f11b11effe1a1acde6e6928 quvi-0.1.3.tar.bz2 12ac6a254f11b11effe1a1acde6e6928 quvi-0.1.3.tar.bz2.1 [+] MUST: The package MUST successfully compile and build into binary rpms. koji scratch builds: F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2090760 F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2090753 [.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [+] MUST: Packages storing shared library files must call ldconfig in %post and %postun. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot}. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' [+] MUST: .so (without suffix) must go in a -devel package. [+] MUST: devel packages must require the base package [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications ... [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. - builds in mock [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [+] SHOULD: pkgconfig(.pc) should be placed in a -devel pkg. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review