Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571364 --- Comment #7 from Miloslav Trmač <mitr@xxxxxxxxxx> 2010-04-01 11:37:55 EDT --- rpmlint: > man-db.src: W: spelling-error %description -l en_US whatis -> whats, what's, what is > (other "spelling error" warnings, some bogus, some correct) > man-db.src:34: W: configure-without-libdir-spec This doesn't seem to be a problem... but see below about %configure > man-db.x86_64: W: incoherent-version-in-changelog 2.5.7-1 ['2.5.7-5.fc12', '2.5.7-5'] Trivial to fix. %doc must include docs/COPYING*. Other files to consider: doc/HACKING, doc/TODO, ChangeLog, NEWS; I think including at least NEWS would be useful. I'm not sure about "Provides: man = %{version}": at the very least it should be "%{version}-%{release}". Requires: crontabs should be added to handle /etc/cron.daily ownership. man-db should own /usr/libexec/man-db Wouldn't it be cleaner to use %configure than to use --with-config-file and make CC= ? Please use only one of %{buildroot} and $RPM_BUILD_ROOT, and %global instead of %define. PackagingGuidelines recommend adding BuildRequires: gettext. Consider using (make install INSTALL='install -p' ...) to preserve timestamps. "All patches should have an upstream bug link or comment" Would it make sense to use /etc/sysconfig/man-db instead of adding new options to /etc/man_db.conf ? For example, if upstream ever tightened the parser to reject invalid values, Fedora would have to loosen the checking again. Is the man-pages-de translation of man-db man pages better? Knowing nothing (and not having looked), I'd assume the man pages shipped with the project would be more likely to be up-to-date. "install -d m 0755 $RPM_BUILD_ROOT%{cache}" seems to be missing a '-' before 'm'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review