Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578620 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-01 09:44:31 EDT --- Hi Nicoleau, just some initial comments on your package: - According to the source file header, the license is GPLv3+, not GPLv3 only. - I suggest to put the library into the base package and drop libquivi since both packages are rather small. The name of the devel package would then become quivi-devel. - In the %files section, replace %{name}.1.gz with %{name}.1*. It's better not to rely on a specific compression format. - Don't add file COPYING several times. It's sufficient to place it in the base package. - add a blank line before %changelog :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review