Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561243 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-01 04:58:54 EDT --- Hi Eric, you've done a good job setting up this big package. Here are a couple of things I've noticed so far: - change the Source0 URL to http://downloads.sourceforge.net/%{name}/MeshLabSrc_v122.tar.gz (see https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net) - the following doc files use the ISO-8859-1 character set: meshlab/docs/contrib_Gangemi_Vannini.txt meshlab/docs/contrib_Buzzelli_Mazzanti.txt convert them to UTF-8, e.g. with: cd meshlab/docs/ for f in contrib_Gangemi_Vannini.txt contrib_Buzzelli_Mazzanti.txt; do iconv -fiso88591 -tutf8 $f >$f.new touch -r $f $f.new mv $f.new $f done - I suggest to add trailing slashes after folder names in the %files section: %{_libdir}/meshlab/ %{_datadir}/meshlab/ This way it's easier to see that directories are added and not single files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review