Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtcd - Tide Constituent Database Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211623 bugs.michael@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx ------- Additional Comments From bugs.michael@xxxxxxx 2006-10-20 16:30 EST ------- Several issues: * First of all, I don't think this split-off is convenient. It increases maintenance requirements with questionable benefit: - upstream do not ship libtcd in a separate tarball - you include the xtide tarball in two src.rpms - you introduce an own SONAME and ABI - you can update xtide without building an included newer libtcd As long as upstream doesn't treat libtcd as a separate release, why don't you build packages "libtcd", "libtcd-devel" and "tcd-utils" from inside the xtide src.rpm instead? What other programs want libtcd? * Versioning: > +SOMAJOR = 21 > +SOMINOR = 0 > +SOVER = 3 Upstream uses MAJOR_REV 2 and MINOR_REV 1. Where does your versioning scheme originate? As long as upstream uses only static libs, do you want to increase major/minor/release appropriately? * Shipping the headers in standard search path pollutes the global namespace with generic file names. Much better would be to install them into %_includedir/libtcd/ $ rpmls -p libtcd-devel-2.1.3-1.i386.rpm -rw-r--r-- /usr/include/nvtypes.h -rw-r--r-- /usr/include/tcd.h -rw-r--r-- /usr/include/tide_db_default.h -rw-r--r-- /usr/include/tide_db_header.h -rw-r--r-- /usr/include/tide_db_version.h lrwxrwxrwx /usr/lib/libtcd.so drwxr-xr-x /usr/share/doc/libtcd-devel-2.1.3 -rw-r--r-- /usr/share/doc/libtcd-devel-2.1.3/libtcd.html * Hint: > ln -sf $f $RPM_BUILD_ROOT%{_libdir}/`echo $f | sed -e 's|.[^.][^.]*.[^.][^.]*$||'` > ln -sf $f $RPM_BUILD_ROOT%{_libdir}/`echo $f | sed -e 's|.so.*$|.so|'` You could simply run cd $RPM_BUILD_ROOT%{_libdir} ln -s libtcd.so.* libtcd.so /sbin/ldconfig -n $(pwd) cd - which would be much easier to the eyes. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review