Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562097 --- Comment #4 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-03-31 15:39:47 EDT --- Here's the full review. The license need to be reverted to what mojito has (but with LGPLv2, not LGPLv2.1 -- see http://fedoraproject.org/wiki/Licensing#Good_Licenses And if you could locate a source tarball now that moblin.org is down, and update the SRPM, I could approve the review. Review ====== Problems -------- rpmlint: only one real warning, the invalid URL. Change to new MeeGo URL when committing $ rpmlint libsocialweb-0.24.0-1.fc12.src.rpm ~/Downloads/libsocialweb* libsocialweb.src: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate, aggressor libsocialweb.src: W: invalid-url Source0: http://download.moblin.org/sources/libsocialweb/0.24/libsocialweb-0.24.0.tar.bz2 HTTP Error 404: Not Found libsocialweb.x86_64: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate, aggressor 4 packages and 0 specfiles checked; 0 errors, 3 warnings. License accurate: FIX -- a spot check shows that many files are LGPLv2 without any mention of using any later version. Upstream source: FIX -- can't check until MeeGo downloads available Passes ------ Package & spec names: OK Fit for inclusion: OK (rename of existing mojito) Content: OK License acceptable: OK License included: OK Spec language: OK (US English, legible) Compiles: OK see http://koji.fedoraproject.org/koji/taskinfo?taskID=2087590 Complete BRs: OK Locale: OK ldconfig: OK no bundled libs: OK Dir ownership: OK No dup files: OK File perms: OK UTF-8 files: OK %clean: OK rm on %install: OK Consistent macros: OK Large docs: NA %doc unessential: OK Headers in -devel: OK *.so.* -> *.so in -devel: OK Static in -static: NA -devel Req: main: OK No .la: OK Desktop files: NA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review