[Bug 576673] Review Request: beaker - Automated test system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576673

--- Comment #4 from Till Maas <opensource@xxxxxxxxx> 2010-03-31 10:23:00 EDT ---
Hello Bill,

(In reply to comment #2)

> Question about python_sitelib is not declard condtionally.  I thought the below
> code was conditional.
> 
> %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print get_python_lib()")}
> 
> !? should say if its not defined right?

The guidelines currently add a condition on the Fedora release:

%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%endif

> And for python-devel to python2-devel.  Should All python be changed to
> python2-*?

No, currently it should be only python2-devel

For references, please take a look at the python packaging guidelines:
http://fedoraproject.org/wiki/Packaging:Python


(In reply to comment #3)

> Another question on macro sharedstatedir,  it expands into the following on my
> F12 machine:
> 
> %_sharedstatedir %{_prefix}/com

Do you maybe have this defined in your ~/.rpmmacros? In EPEL 4 & 5, this
happens, too. But it should not on F12 and does not happen on my F12 machines
and I know of another package in Fedora that uses %_sharedstatedir and works
for F11+, it's gitolite if you want to look at it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]