Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578269 Germán Racca <gracca@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracca@xxxxxxxxx --- Comment #2 from Germán Racca <gracca@xxxxxxxxx> 2010-03-30 21:14:42 EDT --- Hello jjwei: Just a few comments on your package. I'm looking for sponsorship also. It's useful to put the output of rpmlint here. I'm doing it for you: [german@skytux Downloads]$ rpmlint ../rpmbuild/RPMS/i686/xgospel-1.12d-1.fc12.i686.rpm xgospel.i686: W: spelling-error %description -l en_US weiqi -> weird, Weiss, Weill xgospel.i686: W: non-standard-group Games xgospel.i686: W: incoherent-version-in-changelog 1.12d-0.docs.1 ['1.12d-1.fc12', '1.12d-1'] xgospel.i686: W: invalid-license GPL xgospel.i686: W: unstripped-binary-or-object /usr/bin/rport xgospel.i686: W: unstripped-binary-or-object /usr/bin/xgospel 1 packages and 0 specfiles checked; 0 errors, 6 warnings. OK, the comments now: ** non-standard-group: the correct group should be "Amusements/Games" in this case ** incoherent-version-in-changelog: the version should be "1.12d-1", and I also think that one changelog entry with the list of all changes is enough in this case, because all of them belong to version 1.12d-1 ** invalid-license GPL: please read carefully the file "my/COPYRIGHTS" to choose the proper value for this tag Also, you don't need to put "gcc" in BuildRequires. See here: https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 Good luck! Germán. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review