Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fluxstyle - Graphical style manager for fluxbox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211548 ------- Additional Comments From miker5slow@xxxxxxxxxxxxx 2006-10-20 13:48 EST ------- (In reply to comment #4) > * There are missing: > > %dir %{_datadir}/%{name}-%{version}/glade/ > %dir %{_datadir}/%{name}-%{version}/images/ > > * The .desktop file don't seem very right to me: > > - the MimeType seems very wrong What do you think it should be? > - In the categories, tere should certainly de somthing like > System or Utilities. Is there one that it should be more than the other, or do you think both maybe? > - Icon entry is missing (and no icon is packaged) > If the icon is fluxbox48x48-trans-metal-bevel.png, it should be > copied to hicolor theme/48x48..... and the scriptlets should be > called. What icon is this for?? The one you are talking about is used in the aboutDialog > * I am not convinced that fluxStyle.p* is rightly in > /usr/lib/python2.4/site-packages/fluxstyle/, since it seems to be the > same than the fluxStyle script in %_bindir. Am I missing something? I didnt even realize I had this, I pulled it from svn > * I don't thtink the shebang of > /usr/lib/python2.4/site-packages/fluxstyle/__init__.py is right. > It seems to me that it shouldn't have a shebang, and shouldn't be > executable. > > I am not very knowledgable in python so the last 2 comments may be > wrong. You are right, I fixed this in svn and I am making a 1.0.1 release with this fix and the one above. Ill put up another spec/src.rpm when I get home and get a chance to make sure it all works :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review