[Bug 578135] Review Request: patcher - Quick creation of patches against a project source tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578135

--- Comment #3 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-03-30 18:07:28 EDT ---
I use this (however, might be outdated, rpm seems to compile itself these days)

%build
%{__python} setup.py build

%install
rm -rf %{buildroot}
%{__python} setup.py install -O1 --skip-build --root %{buildroot}

Why do you want to remove pyc files?

You have to escape macros in changelog %foo -> %%foo.

Please be more explicit in %files, spell out the %{_bindir} line.

I would move this to prep section:

# remove rpmlint warning
%{__sed} -i -e 's|^#!/usr/bin/python.*||'
$RPM_BUILD_ROOT/%python_sitelib/%{name}/{commands,}/*py


Don't lift to 1.1, use 2 and now 3.

And now some pedantic stuff: I like Summary on top and no empty lines in the
top section.


koji builds fine:

 http://koji.fedoraproject.org/koji/taskinfo?taskID=2085482

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]