Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=572512 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #5 from Jon Ciesla <limb@xxxxxxxxxxxx> 2010-03-30 10:02:25 EDT --- Ok, let's see what I've got so far. # MUST: rpmlint must be run on every package. The output should be posted in the review.[1] [limb@paguroidea SPECS]$ rpmlint -i ../SRPMS/gluegen-1.0.20102502svn-4.fc12.src.rpm gluegen.src: W: invalid-url URL: https://gluegen.dev.java.net/ <urlopen error [Errno -3] Temporary failure in name resolution> The value should be a valid, public HTTP, HTTPS, or FTP URL. OK, I was offline. gluegen.src: W: invalid-url Source0: gluegen-1.0.20102502svn.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. OK, SVN checkout. 1 packages and 0 specfiles checked; 0 errors, 2 warnings. On the initail rpmlint run, there were tons of "internal vcs file" warnings. Add the following to your tarball generation process: find -name '.svn' | xargs rm -rf After correcting this and rebuilding: [limb@paguroidea SPECS]$ rpmlint -i ../RPMS/*/gluegen* gluegen.i686: W: invalid-url URL: https://gluegen.dev.java.net/ <urlopen error [Errno -3] Temporary failure in name resolution> The value should be a valid, public HTTP, HTTPS, or FTP URL. gluegen-debuginfo.i686: W: invalid-url URL: https://gluegen.dev.java.net/ <urlopen error [Errno -3] Temporary failure in name resolution> The value should be a valid, public HTTP, HTTPS, or FTP URL. gluegen-debuginfo.i686: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. FIX I'm not sure how this should work, as my Java-fu is weak. If you can't fix this, disable the debuginfo as a last resort. gluegen-source.noarch: W: invalid-url URL: https://gluegen.dev.java.net/ <urlopen error [Errno -3] Temporary failure in name resolution> The value should be a valid, public HTTP, HTTPS, or FTP URL. OK, see above. gluegen-source.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. FIX gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/net/highteq/nativetaglet/NativeTaglet.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/dynlink-unix-CustomJavaCode.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/build.xml This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/BufferFactory.java.javame_cdc_fp This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/StructAccessor.java.javame_cdc_fp This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/UnixDynamicLinkerImpl.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/opengl/GLJavaMethodBindingEmitter.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/procaddress/ProcAddressCMethodBindingEmitter.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/gluegen.properties.antlr-properties.patch This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/validate-properties.xml This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/dynlink-windows-CustomJavaCode.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: W: spurious-executable-perm /usr/share/gluegen-source/gluegen/make/stub_includes/unix/dynamic-linker.h The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/BufferFactory.java.javase This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/procaddress/ProcAddressConfiguration.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/procaddress/ProcAddressEmitter.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: W: spurious-executable-perm /usr/share/gluegen-source/gluegen/src/native/windows/WindowsDynamicLinkerImpl_JNI.c The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/DynamicLookupHelper.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/NativeLibLoader.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: W: spurious-executable-perm /usr/share/gluegen-source/gluegen/src/native/unix/UnixDynamicLinkerImpl_JNI.c The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/DynamicLinker.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/BufferFactoryInternal.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/opengl/GLConfiguration.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/StructAccessor.java.javase This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: W: spurious-executable-perm /usr/share/gluegen-source/gluegen/make/stub_includes/windows/dynamic-linker.h The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/Manifest This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/dynlink-unix.cfg This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/gluegen.properties This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/dynlink-macosx.cfg This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/gluegen-cpptasks.xml This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/nativesig/NativeSignatureEmitter.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/MacOSXDynamicLinkerImpl.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/nativesig/NativeSignatureJavaMethodBindingEmitter.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/lib/cpptasks-version.txt This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: W: spurious-executable-perm /usr/share/gluegen-source/gluegen/make/stub_includes/macosx/dynamic-linker.h The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/dynlink-windows.cfg This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/make/gluegen-cpptasks.xml.no-solaris.patch This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/procaddress/ProcAddressJavaMethodBindingEmitter.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: world-writable /usr/share/gluegen-source/gluegen 0777 A file or directory in the package is installed with world writable permissions, which is most likely a security issue. gluegen-source.noarch: E: non-standard-dir-perm /usr/share/gluegen-source/gluegen 0777 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/CPU.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/pcpp/ConcatenatingReader.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/cgram/types/SizeThunk.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: W: spurious-executable-perm /usr/share/gluegen-source/gluegen/src/native/macosx/MacOSXDynamicLinkerImpl_JNI.c The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/WindowsDynamicLinkerImpl.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. gluegen-source.noarch: E: script-without-shebang /usr/share/gluegen-source/gluegen/src/java/com/sun/gluegen/runtime/NativeLibrary.java This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. FIX You can fix all of the above using find -name '*.java' | xargs chmod -x, rinse and repeat for .c, .xml, etc as needed. 3 packages and 0 specfiles checked; 40 errors, 10 warnings. # MUST: The package must be named according to the Package Naming Guidelines . OK # MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . OK # MUST: The package must meet the Packaging Guidelines . Looks like it doesn't run afoul of the Java guidelines. # MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . BSD: OK Apple Public Source License: OK make/stub_includes/unix/dynamic-linker.h Copyright 1989 AT&T?!?!?!??! What license is this file? It says it's extracted from Solaris? # MUST: The License field in the package spec file must match the actual license. [3] See above. At this point, it should be BSD and APSL 2.0 # MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] OK, pending above. # MUST: The spec file must be written in American English. [5] OK # MUST: The spec file for the package MUST be legible. [6] OK # MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK, SVN checkout. # MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] OK, builds on i686. # MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8] OK # MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, mock rawhide build was fine. # MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] OK # MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] FIX ldconfig is not called. # MUST: Packages must NOT bundle copies of system libraries.[11] OK # MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12] NA # MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] OK # MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [14] OK # MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [15] See above. # MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [16] OK # MUST: Each package must consistently use macros. [17] OK # MUST: The package must contain code, or permissable content. [18] OK # MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [19] NA # MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [19] OK # MUST: Header files must be in a -devel package. [20] OK, the few .h are in -source # MUST: Static libraries must be in a -static package. [21] NA # MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). [22] NA # MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [20] NA # MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [23] NA # MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[21] OK # MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [24] NA # MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [25] OK # MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [26] OK # MUST: All filenames in rpm packages must be valid UTF-8. [27] OK So, it looks like it's the license issue, the svn files, documentation, debuginfo and file permissions. Unless I missed something. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review