[Bug 577932] Review Request: python-geoclue - A Geoclue python module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577932

--- Comment #2 from Peter Robinson <pbrobinson@xxxxxxxxx> 2010-03-29 16:55:40 EDT ---
Thanks!

> Needswork:
> - %files
>   * you should change 0.1.0 to %{version}, this way you don't need to change
> this all the time.
>   * how about %doc docs/* ?
> 
> - license wrong: GPLv3 -> GPLv3+
> 
> - BR wrong:
>   * What is pygobject2-devel for?
>     Please BR pygobjec2 instead (only the python files are needed, not the
> whole -devel package).
>   * Instead you need to also Require pygobject2 for python importing on runtime

I believe these are all fixed now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]