Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571993 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-03-29 08:51:17 EDT --- Just a couple of quick comments: - according to the source file headers, the license seems to be GPLv2+ - add the following line to the %prep section in order to disable early stripping of debuginfo: sed -i '/^ifneq (\$(USE_DEBUG),yes)/,+4 d' Makefile (alternatively, you can patch the Makefile) - the configure command in the %build section should look like this: %configure --enable-lash - I think, the documentation is extensive enough to put it in a separate doc subpackage - add TODO.mu to %doc $ rpmlint /var/lib/mock/fedora-12-i386/result/*.rpm non-sequencer.src:38: W: configure-without-libdir-spec non-sequencer.src: W: invalid-url Source0: non-sequencer-20100131gitba94d2c354145.tar.bz2 non-sequencer-debuginfo.i686: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 1 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review