Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577015 --- Comment #5 from Sebastian Dziallas <sebastian@xxxxxxxx> 2010-03-28 19:00:32 EDT --- Alright, here comes the review stuff. It looks like upstream is currently still moving stuff around between Moblin and Meego, so I can currently check neither version numbering nor the latest version. A couple of comments: * please you either %{buildroot} or $RPM_BUILD_ROOT * there's apparently some noise in rpmlint - the spelling errors can obviously be ignored but the other stuff might need an eye. As soon as upstream gets the repo up again, we should be able to proceed here. [ OK ] specfiles match: 46952998dd5bcd4925e693285a6464da [ -- ] source files match upstream: N/A [ -- ] package meets naming and versioning guidelines. [ -- ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ -- ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=2076085 [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ -- ] rpmlint is silent: [sebastian@localhost ~]$ rpmlint mutter-mbl-2.28.1_0.12-1.fc14.i686.rpm mutter-mbl.i686: W: spelling-error Summary(en_US) compositing -> composting, com positing, com-positing mutter-mbl.i686: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing mutter-mbl.i686: W: incoherent-version-in-changelog 2.28.1_0.10-1 ['2.28.1_0.12-1.fc14', '2.28.1_0.12-1'] mutter-mbl.i686: W: shared-lib-calls-exit /usr/lib/libmutter-private.so.0.0.0 exit@xxxxxxxxx mutter-mbl.i686: W: non-conffile-in-etc /etc/gconf/schemas/mutter.schemas 1 packages and 0 specfiles checked; 0 errors, 5 warnings. [sebastian@localhost ~]$ rpmlint mutter-mbl-devel-2.28.1_0.12-1.fc14.i686.rpm mutter-mbl-devel.i686: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [sebastian@localhost ~]$ rpmlint mutter-mbl-debuginfo-2.28.1_0.12-1.fc14.i686.rpm mutter-mbl-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/mutter-2.28.1_0.12/src/compositor/mutter-shaped-texture.c 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [ OK ] final provides and requires are sane [ NA ] %check is present and all tests pass [ OK ] no shared libraries are added to the regular linker search paths. [ NA ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] docs subpackage is appropriately created [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] headers go into devel package. [ OK ] pkgconfig files are in devel package. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review