[Bug 577680] Review Request: banshee-community-extensions - Collection of extensions for the media player Banshee

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577680

--- Comment #2 from Christian Krause <chkr@xxxxxxxxxxx> 2010-03-28 18:50:49 EDT ---
(In reply to comment #1)
> - Should it better require a specific banshee version? As seen with
> banshee-mirage there is the possibility that banshee API updates together with
> old extensions can crash banshee.
> This would require us to always update the extensions together with banshee,
> which seems a bit difficult for me. Comments?

I would not recommend this:

- banshee-community-extensions's configure script will (during compile time)
ensure, that at least a supported banshee version is availabe - as long as we
don't downgrade banshee this will ensure, that this condition is also met for
the binary packages

- pinpointing to an exact version will IMHO generate unnecessary rebuilds

- I assume that lots of people will have installed the extensions anyway and so
it is very likely that the problems are caught either during packaging or
during the testing period

So all in all I suggest not to require a specific banshee version.

> - Maybe we should create sub-packages and not put all extensions in one
> package?

I'm not sure about this:
There are two reasons which come to my mind why this could be helpful:
1. the full package is unreasonable big
or
2. the full package pulls in lots of dependencies which are only needed for
some extensions

But since the package itself is only about 1 MByte I don't think it is
necessary because of the size.

Regarding the dependencies "rpm -qR banshee-community-extensions" does not
reveal anything critical. Most dependent packages are already installed because
of other nearly-always-installed packages require them anyway (e.g. the deps of
mirage are pulled in by pulseaudio and kdemultimedia).

So far I don't see a strong need for splitting up the package into
sub-packages. But I don't have a very strong opinion on this... ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]