Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530649 --- Comment #7 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-03-28 10:37:52 EDT --- Sorry, it took a bit longer... Thanks for the review. (In reply to comment #6) > Review: massxper > Date: 19th March 2010 > Koji Build: Seems to be timing out :-( I build this with ccache & rpmbuild: real 2m11.115s user 1m18.720s sys 1m25.074s So it can take a while ;) Koji build successfull http://koji.fedoraproject.org/koji/taskinfo?taskID=2079497 > > * COMMENT: rpmlint output > $ rpmlint ../SRPMS/massxpert-2.1.0-1.fc14.src.rpm > ../RPMS/noarch/massxpert-doc-2.1.0-1.fc14.noarch.rpm > ../RPMS/x86_64/massxpert-2.1.0-1.fc14.x86_64.rpm > ../RPMS/x86_64/massxpert-debuginfo-2.1.0-1.fc14.x86_64.rpm > massxpert.src: W: spelling-error %description -l en_US spectrometric -> > spectrometer, spectroscopic, spectroscopy > massxpert.x86_64: W: spelling-error %description -l en_US spectrometric -> > spectrometer, spectroscopic, spectroscopy Completely rewrite (with help from upstream website): $ rpmlint massxpert-2.1.0-2.fc13.src.rpm noarch/massxpert-doc-2.1.0-2.fc13.noarch.rpm x86_64/massxpert-2.1.0-2.fc13.x86_64.rpm x86_64/massxpert-debuginfo-2.1.0-2.fc13.x86_64.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. > * NO: Handle locales properly. > > /usr/share/massxpert/locales > /usr/share/massxpert/locales/massxpert_fr.qm > > could be handled better. Now the %files section looks a bit nasty, but don't know how to do it different... Was is that, what you meant? %doc %lang(fr) %{_datadir}/massxpert/locales/massxpert_fr.qm > ----------- > > Comments: > Could you rewrite the description just to avoid the word spectrometric? > > Work to be done: > Just that one locale file should be handled. %changelog - rewrite description to make rpmlint silent - renew %%files (better handle locales) Spec URL: http://tomspur.fedorapeople.org/review/massxpert.spec SRPM URL: http://tomspur.fedorapeople.org/review/massxpert-2.1.0-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review