Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549366 --- Comment #17 from Andrea Musuruane <musuruan@xxxxxxxxx> 2010-03-28 05:12:36 EDT --- First, you can begin calling me using my first name and not my surname. I think that this review makes me an acquaintance :-) * Please remove commented Source1 lines, since you don't use them. * Now you are mixing macro styles: https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS * Issue 4 is still not solved. You did a funny thing. "install -p" is a command not a make option. This is not a mandatory issue. If you want to fix it, please read again: https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps * The following comment #fix shebang on rpmlint should be better changed to: # Fix spurious executable permissions * If desktop file is already installed by the install process (and what is installed is semantically correct), use desktop-file-validate instead of desktop-file-install: https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage * Please report the bugs you found in the desktop file upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review