Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540617 --- Comment #22 from Till Maas <opensource@xxxxxxxxx> 2010-03-27 14:38:27 EDT --- [UNCLEAR] rpmlint output: django-lint.src: W: spelling-error %description -l en_US nullable -> null able, null-able, tillable django-lint.src: W: spelling-error %description -l en_US py -> pt, p, y 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Maybe change nullable, probably to null-able. [OK] Spec in %{name}.spec format [OK] license allowed: GPLv3+ [NOT OK] license matches shortname in License: tag [OK] license in tarball and included in %doc: COPYING [OK] package is code or permissive content: {N/A} patches sent to upstream and commented [OK] Source0 is a working URL {N/A} Sourceforge URL is Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz <OK> SourceX / PatchY prefixed with %{name} [OK] Source0 matches Upstream: 374a639fd34c41b29d3a80156ea42b3d django-lint-0.13.tar.bz2 [OK] Package builds on all primary architectures: http://koji.fedoraproject.org/koji/taskinfo?taskID=2078651 [N/A] ExcludeArch bugs are filed and commented: [OK] BuildRequires are complete (mock builds) (OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin [N/A] %find_lang used for locales [N/A] Every (sub)package containing libraries runs ldconfig [N/A] .h (header) files are in -devel subpackage [N/A] .a (static libraries) are in -static subpackage [N/A] contains .pc (pkgconfig) files and has Requires: pkgconfig (N/A) .pc files are in -devel subpackage [N/A] contains .so.X(.Y) files and .so is in -devel [N/A] -devel subpackage has Requires: %{name} = %{version}-%{release} [N/A] .la files (libtool) are not included [OK] does not bundle copies of system libraries [N/A] Has GUI and includes %{name}.desktop [N/A] Follows desktop entry spec [N/A] Valid .desktop Name [N/A] Valid .desktop GenericName [N/A] Valid .desktop Categories [N/A] Valid .desktop StartupNotify [N/A] .desktop file installed with desktop-file-install in %install [OK] Prefix: /usr not used (not relocatable) [OK] Owns all created directories [OK] no duplicates in %files [OK] %defattr(-,root,root,-) is in every %files section [OK] Does not own files or dirs from other packages [OK] included filenames are in UTF-8 [OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT [OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT [OK] Consistent macro usage [N/A] large documentation is -doc subpackage [OK] %doc does not affect runtime (NOT OK) Contains manpage for every executable The source contains django-lint.1, but it is not installed in %{_mandir}/man1/ {OK} no pre-built binaries (.a, .so*, executable) {OK} well known BuildRoot %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) {OK} PreReq not used https://fedoraproject.org/wiki/Packaging/Guidelines#PreReq {N/A} RPM_OPT_FLAGS honoured https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags {N/A} Useful debuginfo generated https://fedoraproject.org/wiki/Packaging/Guidelines#Debuginfo_packages {OK} no duplication of system libraries https://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries {OK} no rpath https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath {CHECKLATER} Timestamps preserved with cp and install Don't forget to use -p with install to install the manpage {N/A} Uses parallel make (%{?_smp_mflags}) https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make {OK} Requires(pre,post) style notation not used https://fedoraproject.org/wiki/Packaging/Guidelines#Scriptlets_requirements {OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and %{buildroot} on %install and %clean) https://fedoraproject.org/wiki/Packaging/Guidelines#Scriplets_are_only_allowed_to_write_in_certain_directories {OK} no Conflicts https://fedoraproject.org/wiki/Packaging/Conflicts {OK} nothing installed in /srv https://fedoraproject.org/wiki/Packaging/Guidelines#No_Files_or_Directories_under_.2Fsrv {OK} Changelog in allowed format {OK} does not use Scriptlets <OK> Architecture independent packages have: BuildArch: noarch <OK> Sane Provides: and Requires: {OK} Follows Naming Guidelines Python https://fedoraproject.org/wiki/Packaging:Python {OK} Has BuildRequires: python2-devel and/or python3-devel https://fedoraproject.org/wiki/Packaging:Python#BuildRequires {OK} Defines and uses %{python_sitelib} or %{python_sitearch}: %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif https://fedoraproject.org/wiki/Packaging:Python#Macros [OK] Python eggs must be built from source. They cannot simply drop an egg from upstream into the proper directory. [OK] Python eggs must not download any dependencies during the build process. [OK] If egg-info files are generated by the modules build scripts they must be included in the package. [N/A] When building a compat package, it must install using easy_install -m so it won't conflict with the main package. [N/A] When building multiple versions (for a compat package) one of the packages must contain a default version that is usable via "import MODULE" with no prior setup. (N/A) A package which is used by another package via an egg interface should provide egg info. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review