Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576431 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-03-27 09:36:44 EDT --- Just a couple of quick comments: - if the final upstream release will be 1.25 (i.e. drops the trailing "b"), change the version number to 1.25 and the release tag to 0.1.b%{dist} (see http://fedoraproject.org/wiki/PackageNamingGuidelines#Pre-Release_packages) - the package doesn't build in mock because of a missing BR: libidn-devel - in the %files section, replace %{_datadir}/* with %{_datadir}/%{name}/ - also in the %files section, replace %attr(755,root,root) /usr/bin/skipfish with %{_bindir}/%{name} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review