Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573448 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-03-27 04:46:29 EDT --- Adrien, is this your first package? I can't find you in the Fedora Account System. If so, you have to be sponsored to become a packager (see https://fedoraproject.org/wiki/PackageMaintainers/Join). To find one, add FE-NEEDSPONSOR to the Blocks field above. A couple of quick comments on your package: - The summary should not mention the package name. Simply replace it by "A simple utility for creating and reading constant data bases" - According to the source code headers and the website, TinyCDB is Public Domain software, so change the license from "GPL" to "Public Domain". - Add short comments above Patch0 and Patch1 describing what they do - The lines of the description text should not exceed 80 characters. Split them properly. - File libcdb.so must be placed in the devel package. - You must call ldconfig in %post and %postun (see https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries) - Replace the man page suffixes ".gz" with "*", e.g. %{_mandir}/man1/cdb.1* since packages shouldn't rely on a specific compression format. - The version/revision number is missing in the changelog entry: * Sun Mar 14 2010 Adrien Bustany <abustany@xxxxxxxxx> - 0.77-1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review