Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577058 --- Comment #2 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-03-25 22:52:18 EDT --- PERL_INSTALL_ROOT is probably better off as DESTDIR... May have missed that last time around :) Aside from that, looks good! koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2076462 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 4b2f2821484d023ab1f7218e4362b752b7bffacc SVG-TT-Graph-0.12.tar.gz 4b2f2821484d023ab1f7218e4362b752b7bffacc SVG-TT-Graph-0.12.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-SVG-TT-Graph-0.12-1.fc13.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-SVG-TT-Graph-0.12-1.fc13.noarch.rpm perl(SVG::TT::Graph) = 0.12 perl-SVG-TT-Graph = 0.12-1.fc13 perl(SVG::TT::Graph::Bar) = 0.11 perl(SVG::TT::Graph::BarHorizontal) perl(SVG::TT::Graph::BarLine) perl(SVG::TT::Graph::Line) perl(SVG::TT::Graph::Pie) perl(SVG::TT::Graph::TimeSeries) = 0.11 ====> requires for perl-SVG-TT-Graph-0.12-1.fc13.noarch.rpm perl(base) perl(Carp) perl(Data::Dumper) perl(DateTime) perl(HTTP::Date) perl(:MODULE_COMPAT_5.10.1) perl(POSIX) perl(strict) perl(SVG::TT::Graph) perl(Template) perl(vars) =====> perl-SVG-TT-Graph-0.12-1.fc13.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-SVG-TT-Graph-0.12-1.fc13.src.rpm ====> requires for perl-SVG-TT-Graph-0.12-1.fc13.src.rpm perl(DateTime) perl(ExtUtils::MakeMaker) perl(HTTP::Date) perl(Template) perl(Test::More) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review