Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576724 --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-03-25 04:54:51 EDT --- $ rpmlint rng-tools-* rng-tools.src: W: invalid-url Source0: http://download.sourceforge.net/gkernel/rng-tools-2.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - Change Requires: /sbin/chkconfig /sbin/service to Requires: chkconfig initscripts to speed up dependency resolution. - Patch1 but no Patch0? - Must Obsoletes: rng-utils <= 1:2.0-4 . - Source URL should be http://downloads.sourceforge.net/gkernel/rng-tools-2.tar.gz not http://download.sourceforge.net/gkernel/rng-tools-2.tar.gz Ideally %{version} macro should be used here. - %configure picks up correct compiler flags. make CFLAGS="$RPM_OPT_FLAGS" should be make %{?_smp_mflags} to enable SMP compilation. - Macros are mixed. After correction of above (make) problem, there aren't any macro problems any more. - You can drop mkdir -p %{buildroot}%{_sbindir} mkdir -p %{buildroot}%{_initrddir} mkdir -p %{buildroot}%{_sysconfdir}/sysconfig mkdir -p %{buildroot}%{_mandir}/man{1,8} as this is (or at least should be!) automatically done by make install. - If you %define _sbindir /sbin at the top of the spec file, you can use plain %configure and %{_sbindir} in %files. - You might want to change the .gz suffixes of the man pages to .* in %files. - Add AUTHORS, ChangeLog, COPYING, NEWS and README to %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review