Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566598 Germán Racca <gracca@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracca@xxxxxxxxx --- Comment #2 from Germán Racca <gracca@xxxxxxxxx> 2010-03-24 18:47:50 EDT --- Hello FLOZz: This is not an official review, but some preliminary observations: 1. At first glance I can see that you need to prefix configuration files with %config (as indicated by the output of rpmlint) as follows: %config %{_sysconfdir}/gconf/schemas/cover-thumbnailer.schemas 2. BuildRoot is no more needed, so you can remove the line: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 3. Also don't need to remove and create buildroot in install section, so you can remove the lines: rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT Hope this helps you. Cheers, Germán. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review