Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561470 --- Comment #14 from James Laska <jlaska@xxxxxxxxxx> 2010-03-24 13:59:20 EDT --- Thanks for the updates Petr. Those changes look good. While re-reviewing the licensing, I noticed that the file 'src/test/shunit2' lists LGPL in the header. There's the issue of lining up the licensing information of shunit2. Before handling lining up with the license in the header of 'src/test/shunit2', I think we need to clarify whether this constitutes bundling a library. Is this code upstream somewhere? Perhaps one of these projects? * shunit - http://shunit.sourceforge.net/ * shunit2 - http://code.google.com/p/shunit2/ Can you explain how shunit2 is used? The 'src/test/README' file doesn't seem to have correct links to the project. Either way, I suspect we might not be allowed to include another project inside beakerlib. I have a suspicion shunit2 would need to be packaged separately in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review