Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575005 --- Comment #9 from Chen Lei <supercyper@xxxxxxx> 2010-03-24 09:06:17 EDT --- (In reply to comment #8) > Here are the new version of zinnia-tomoe package: > Spec URL: http://pwu.fedorapeople.org/zinnia-tomoe/zinnia-tomoe.spec > SRPM URL: > http://pwu.fedorapeople.org/zinnia-tomoe/zinnia-tomoe-0.6.0.20080911-2.fc12.src.rpm > Please review this new package, thanks in advance. > Here are the summary of changes: > As the model data in this package is arch-dependant, built this package as > arch-dependant too. > And fixed the model data path in the Makefile.am: > -modeldir = @prefix@/lib/zinnia/model/tomoe > +modeldir = @libdir@/zinnia/model/tomoe > There is a known rpmlint error report, which said the package should be noarch. > Currently I can't work around this rpmlint report, just ignore it. > Alternatively maybe we can merge the model file to zinnia package as a > sub-package? 1.rpmlint error can be ignored, you shoud add %global debug_package %{nil} in the specfile. See http://fedoraproject.org/wiki/Packaging:Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_other_reasons 2. Version: 0.6.0.20080911 Release: 2%{?dist}-> Version: 0.6.0 Release: 2.20080911%{?dist} I think 20080911 should be added to the release field. 3. License field is not right. See http://tomoe.svn.sourceforge.net/viewvc/tomoe/tomoe/trunk/COPYING?revision=369&view=markup -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review