Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #17 from Mario Ceresa <mrceresa@xxxxxxxxx> 2010-03-21 09:29:46 EDT --- Hello Leon, I'm glad to hearing from you and I hope that nothing serious passed to your family. As for the review, I think we are very close to the approval: please note that the python packaging guidelines at: https://fedoraproject.org/wiki/Packaging:Python have been recently updated. In summary: - python-sitelib, python_sitearch macro are now automatically defined in F13, so the first line of the spec should be: %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif - You should remove manually the gXlib dir in %prep section, after patching, as an additional security measure to be sure that it's gone at build/exec time %{__rm} -rf googsystray/gXlib/ + Source code is the same as upstream $ md5sum googsystray-1.1.4.tar.gz 2c079c139cdd2e5cbe733816bf27e8ae googsystray-1.1.4.tar.gz $ md5sum rpmbuild/SOURCES/googsystray-1.1.4.tar.gz 2c079c139cdd2e5cbe733816bf27e8ae rpmbuild/SOURCES/googsystray-1.1.4.tar.gz + Builds ok on koji (F12, F13) http://koji.fedoraproject.org/koji/taskinfo?taskID=2066494 http://koji.fedoraproject.org/koji/taskinfo?taskID=2066503 I don't know why rpm does not pick up automatically python-xlib. Maybe Peter knows if we are missing something here. Mario -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review