[Bug 575504] Review Request: metagoofil - Metadata analyzer, information gathering tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=575504

Alex Orlandi <nyrk71@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nyrk71@xxxxxxxxx

--- Comment #1 from Alex Orlandi <nyrk71@xxxxxxxxx> 2010-03-21 06:48:51 EDT ---
(In reply to comment #0)

Informal review

> SRPM URL: http://rebus.webz.cz/d/metagoofil-1.4a-1.fc12.src.rpm2
 - there's a typo in the url of the src.rpm (trailing "2")

> [...] 
> 
> Output from the rpmlint :
> $rpmlint /home/rebus/rpmbuild/SRPMS/metagoofil-1.4a-1.fc12.src.rpm
> /home/rebus/rpmbuild/RPMS/noarch/metagoofil-1.4a-1.fc12.noarch.rpm
> metagoofil.src: W: spelling-error %description -l en_US pdf -> pd, pf, pd f
> [...]
> metagoofil.src: W: spelling-error %description -l en_US ods -> dos, ids, odd
> - list of supported document types in the description

   - use CAPITALS for file extensions (i.e.: use PDF instead of pdf)

> metagoofil.noarch: E: explicit-lib-dependency libextractor
> - explicit dependency is needed because it is executed from the perl script and is not detected automatically

   - In general rpmlint suggests that "You must let rpm find the library
dependencies by itself. Do not put unneeded explicit Requires: tags."
    Anyway in this case it is quite probable that rpm can't find the
dependency, so should be ok.


> metagoofil.noarch: W: spelling-error %description -l en_US pdf -> pd, pf, pd f
> [...]
> metagoofil.noarch: W: spelling-error %description -l en_US ods -> dos, ids, odd
> - list of supported document types in the description

   - same of above (capitalize)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]